Wasmtime GitHub notifications bot (Aug 23 2025 at 00:39): Wasmtime GitHub notifications bot (Aug 23 2025 at 00:39):alexcrichton opened PR #11516 from alexcrichton:fix-min-platform to bytecodealliance:main:
A few various changes have happened in the meantime which means that this wasn't actually testing anything on CI. Notably these changes were made:
Sink icache maintenance into
vm::sysmodules. This is fallout of #11152 where no_std support was added for unix/windows targets. This commit moves the error-on-lack-of-std to theunixandwindowsmodules, relegating the custom module to figure its own pieces out as necessary. This also feels like a more accurate reflection of how responsibilities should be sliced up.The example runner now uses
bail!to return an error in case something bad happens instead of continuing as usual and pretending nothing bad happened.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 23 2025 at 00:39):alexcrichton requested wasmtime-core-reviewers for a review on PR #11516.
Wasmtime GitHub notifications bot (Aug 23 2025 at 00:39):alexcrichton requested pchickey for a review on PR #11516.
Wasmtime GitHub notifications bot (Aug 25 2025 at 16:22):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 25 2025 at 20:45):alexcrichton merged PR #11516.
Last updated: Dec 06 2025 at 06:05 UTC