Wasmtime GitHub notifications bot (Aug 21 2025 at 21:09): Wasmtime GitHub notifications bot (Aug 21 2025 at 21:09):alexcrichton opened PR #11496 from alexcrichton:sound-core-libcalls to bytecodealliance:main:
This commit updates the signature of core wasm libcalls to look more like component libcalls where the instance argument is just an id, not an actual pointer. This is required to make them sound because otherwise it's possible to, in safe Rust, acquire two mutable pointers to the same instance. Implementing this change is made possible by the many many previous refactors to how all of these internals work. All that was required here was changing type signatures and minor updates to the order of operations inside of libcalls.
Closes #11178
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 21 2025 at 21:09):alexcrichton requested pchickey for a review on PR #11496.
Wasmtime GitHub notifications bot (Aug 21 2025 at 21:09):alexcrichton requested wasmtime-core-reviewers for a review on PR #11496.
Wasmtime GitHub notifications bot (Aug 21 2025 at 21:49):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 21 2025 at 21:52):alexcrichton updated PR #11496.
Wasmtime GitHub notifications bot (Aug 21 2025 at 21:52):alexcrichton has enabled auto merge for PR #11496.
Wasmtime GitHub notifications bot (Aug 21 2025 at 22:30):alexcrichton merged PR #11496.
Last updated: Dec 06 2025 at 07:03 UTC