Stream: git-wasmtime

Topic: wasmtime / PR #11463 Change how wasm features/gc support ...

Wasmtime GitHub notifications bot (Aug 19 2025 at 20:10):

alexcrichton requested pchickey for a review on PR #11463.

Wasmtime GitHub notifications bot (Aug 19 2025 at 20:10):

alexcrichton opened PR #11463 from alexcrichton:refactor-feature-handling to bytecodealliance:main:

This commit aims to address #11450 in complementary but somewhat orthogonal ways. First a new Config::gc_support option is added which is hooked up to the CLI as -Wgc-support. This option controls the wasmparser-internal GC_TYPES feature. Its default value, like before, is cfg!(feature = "gc") and additionally enabling it requires the gc crate feature to be enabled.

This commit then additionally updates how wasm features are processed during validating a deserialized module to only require enabled features to be enabled in the host. Previously modules that disabled a feature but the feature was enabled in the host would fail to deserialize. All WebAssembly proposals are additive, however, so it's always ok to disable a feature and then load it into a module that enables the wasm proposal.

Closes #11450

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 19 2025 at 20:10):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11463.

Wasmtime GitHub notifications bot (Aug 19 2025 at 20:48):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 19 2025 at 21:08):

fitzgen merged PR #11463.

Wasmtime GitHub notifications bot (Aug 19 2025 at 21:19):

jsturtevant commented on PR #11463:

Thanks!

Last updated: Dec 06 2025 at 06:05 UTC