Stream: git-wasmtime

Topic: wasmtime / PR #11456 Make core instance allocation an `as...

Wasmtime GitHub notifications bot (Aug 19 2025 at 14:33):

alexcrichton opened PR #11456 from alexcrichton:instance-allocation-async to bytecodealliance:main:

This commit is a step in preparation for #11430, notably core instance allocation, or StoreOpaque::allocate_instance is now an async fn. This function does not actually use the async-ness just yet so it's a noop from that point of view, but this propagates outwards to enough locations that I wanted to split this off to make future changes more digestable.

Notably some creation functions here such as making an Instance, Table, or Memory are refactored internally to use this new async function. Annotations of assert_ready or one_poll are used as appropriate as well.

For reference this commit was benchmarked with our instantiation.rs benchmark in the pooling allocator and shows no changes relative to the original baseline from before-async-PRs.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 19 2025 at 14:33):

alexcrichton requested dicej for a review on PR #11456.

Wasmtime GitHub notifications bot (Aug 19 2025 at 14:33):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11456.

Wasmtime GitHub notifications bot (Aug 19 2025 at 14:56):

alexcrichton closed without merge PR #11456.

Wasmtime GitHub notifications bot (Aug 19 2025 at 14:56):

alexcrichton commented on PR #11456:

Alas should have remembered to run tests. Unfortunately this won't be able to land separately, I'll try to keep this as a separate commit though.

Last updated: Dec 06 2025 at 07:03 UTC