Stream: git-wasmtime

Topic: wasmtime / PR #11455 Add clif instructions tests (`imul_i...

Wasmtime GitHub notifications bot (Aug 19 2025 at 12:38):

yomaytk opened PR #11455 from yomaytk:add-riscv-test to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
The riscv64 backend seems to be missing tests for some CLIF instructions that are included in other architectures. This PR adds the imul_imm and get_return_address instructions.

Wasmtime GitHub notifications bot (Aug 19 2025 at 12:38):

yomaytk requested fitzgen for a review on PR #11455.

Wasmtime GitHub notifications bot (Aug 19 2025 at 12:38):

yomaytk requested wasmtime-compiler-reviewers for a review on PR #11455.

Wasmtime GitHub notifications bot (Aug 19 2025 at 16:41):

fitzgen submitted PR review:

Thanks!

FWIW, imul_imm should be legalized away (and turned into an imul with an iconst operand) at the start of the pipeline and shouldn't ever directly make it to the backend. That said, adding a clif test for what it ultimately compiles down to doesn't do any harm.

Wasmtime GitHub notifications bot (Aug 19 2025 at 17:02):

fitzgen merged PR #11455.

Last updated: Dec 06 2025 at 06:05 UTC