Wasmtime GitHub notifications bot (Aug 15 2025 at 18:20): Wasmtime GitHub notifications bot (Aug 15 2025 at 18:20):alexcrichton opened PR #11441 from alexcrichton:store-while-handling-traps to bytecodealliance:main:
This commit does some preparatory refactoring for #11326 to ensure that a store is available when trap information is being processed. Currently this doesn't leverage the new parameter but it should be leverage-able in #11326.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 15 2025 at 18:20):alexcrichton requested fitzgen for a review on PR #11441.
Wasmtime GitHub notifications bot (Aug 15 2025 at 18:20):alexcrichton requested wasmtime-core-reviewers for a review on PR #11441.
Wasmtime GitHub notifications bot (Aug 15 2025 at 18:23):cfallin commented on PR #11441:
Fantastic, thank you for this! I'll rebase/refactor on top of it -- will be much cleaner for exception processing, as we've discussed.
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:41):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:41):fitzgen created PR review comment:
// should reflect that making `enter_host_from_wasm` suitable. Further
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:41):fitzgen created PR review comment:
I think this comment is outdated now that this isn't using any raw pointers anymore?
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:41):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:41):fitzgen created PR review comment:
(That is, the borrow checker can statically check for the double-mutable-borrowing that this comment was previously addressing)
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:57):alexcrichton updated PR #11441.
Wasmtime GitHub notifications bot (Aug 18 2025 at 19:57):alexcrichton has enabled auto merge for PR #11441.
Wasmtime GitHub notifications bot (Aug 18 2025 at 20:34):alexcrichton merged PR #11441.
Last updated: Dec 06 2025 at 06:05 UTC