wasmtime / PR #11439 feat(p3): begin `wasi:http` implemen... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #11439 feat(p3): begin `wasi:http` implemen...

Wasmtime GitHub notifications bot (Aug 15 2025 at 12:15):

rvolosatovs edited PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 12:16):

rvolosatovs edited PR #11439:

Move tests from https://github.com/bytecodealliance/wasip3-prototyping and generate bindings, mostly to simplify future development and review iterations

Wasmtime GitHub notifications bot (Aug 15 2025 at 12:16):

rvolosatovs edited PR #11439:

Move tests from https://github.com/bytecodealliance/wasip3-prototyping and generate bindings to simplify future development and review iterations

Wasmtime GitHub notifications bot (Aug 15 2025 at 12:24):

rvolosatovs updated PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 12:26):

rvolosatovs edited PR #11439:

Move tests from https://github.com/bytecodealliance/wasip3-prototyping and generate bindings to simplify future development and review iterations

refs https://github.com/bytecodealliance/wasip3-prototyping/issues/228
refs https://github.com/bytecodealliance/wasip3-prototyping/issues/109

Wasmtime GitHub notifications bot (Aug 15 2025 at 14:43):

rvolosatovs updated PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 16:46):

alexcrichton created PR review comment:

Mind swapping the order here? (idiomatically closures come last in arguments)

Wasmtime GitHub notifications bot (Aug 15 2025 at 16:46):

alexcrichton created PR review comment:

You can avoid unreachable!() here with match x {} by replacing the _ above with x

Wasmtime GitHub notifications bot (Aug 15 2025 at 16:46):

alexcrichton submitted PR review:

Could the #[ignore] annotations be changed to #[should_panic] or similar? I'm not sure that works with returning a Result<_> though... If not no worries.

Otherwise this feels reasonable to me, land the scaffolding/tests here and slowly get them working one-by-one.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:10):

rvolosatovs updated PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs commented on PR #11439:

Could the #[ignore] annotations be changed to #[should_panic] or similar? I'm not sure that works with returning a Result<_> though... If not no worries.

unfortunately, does not look like this will work:
error: functions using `#[should_panic]` must return `()`
  --> crates/wasi-http/tests/all/p3/incoming.rs:34:1
   |
34 | #[test_log::test(tokio::test)]

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs has marked PR #11439 as ready for review.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs requested wasmtime-wasi-reviewers for a review on PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs requested alexcrichton for a review on PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:11):

rvolosatovs requested wasmtime-default-reviewers for a review on PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:22):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:22):

alexcrichton created PR review comment:

I think this may need to be done self.conn times? (or thread that through here perhaps)

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:40):

rvolosatovs updated PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 17:41):

rvolosatovs has enabled auto merge for PR #11439.

Wasmtime GitHub notifications bot (Aug 15 2025 at 18:16):

rvolosatovs merged PR #11439.

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:58):

rvolosatovs assigned rvolosatovs to PR #11439.

Last updated: Dec 06 2025 at 06:05 UTC