Stream: git-wasmtime

Topic: wasmtime / PR #11421 Add a cwasm produced during testing ...

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:42):

alexcrichton opened PR #11421 from alexcrichton:ignore-a-file to bytecodealliance:main:

Added in wasip3-prototyping but never made its way upstream here, so doing so now.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:42):

alexcrichton requested wasmtime-default-reviewers for a review on PR #11421.

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:42):

alexcrichton requested cfallin for a review on PR #11421.

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:43):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:44):

cfallin commented on PR #11421:

This seems fine, but would it make sense to denylist all *.cwasms instead, with something like /**/*.cwasm? We shouldn't ever check one in to source control, IMHO, because of the version evolution/bootstrapping headaches that would cause...

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:45):

alexcrichton updated PR #11421.

Wasmtime GitHub notifications bot (Aug 12 2025 at 17:45):

alexcrichton has enabled auto merge for PR #11421.

Wasmtime GitHub notifications bot (Aug 12 2025 at 18:15):

bjorn3 commented on PR #11421:

Why are the .cwasm files generated inside the source directory rather than the target directory by the way? Having an immutable source directory is not uncommon for distros.

Wasmtime GitHub notifications bot (Aug 12 2025 at 18:24):

alexcrichton merged PR #11421.

Wasmtime GitHub notifications bot (Aug 12 2025 at 19:27):

alexcrichton commented on PR #11421:

It's an artifact of this test script which is only architected as-is out of convenience, it wouldn't be too hard to modify that to put artifacts elsewhere.

Last updated: Dec 06 2025 at 06:05 UTC