Stream: git-wasmtime

Topic: wasmtime / PR #11410 Make `GcRuntime::take_memory` a safe...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 08 2025 at 21:13):

alexcrichton requested fitzgen for a review on PR #11410.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 08 2025 at 21:13):

alexcrichton opened PR #11410 from alexcrichton:gc-runtime-take-memory-safe to bytecodealliance:main:

This cannot be an unsafe method as it's not possible to provide the guarantee that the memory is placed back in the store (e.g. forget-ing futures). Instead make the method more strict and say that panics will happen if replace_memory isn't called. Existing implementations should already adhere to this.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 08 2025 at 21:13):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11410.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 08 2025 at 23:46):

github-actions[bot] commented on PR #11410:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2025 at 16:09):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2025 at 16:29):

fitzgen merged PR #11410.


Last updated: Dec 06 2025 at 07:03 UTC