Stream: git-wasmtime

Topic: wasmtime / PR #11408 Only create `ir::FuncRef`s for direc...

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:24):

fitzgen opened PR #11408 from fitzgen:dont-make-ir-funcrefs-for-indirect-import-calls to bytecodealliance:main:

We would previously always create Cranelift ir::FuncRefs for the callee of a Wasm call instruction, even if that was a call to an imported function that actually gets translated to an indirect call in CLIF. This commit makes it so that we delay ir::FuncRef creation until we actually emit a direct call.

Also I found that we were not looking for already-created ir::SigRefs when creating ir::FuncRefs, so I fixed that as well, which removes a couple duplicate signature definitions in our disas tests.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:24):

fitzgen requested cfallin for a review on PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:24):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:24):

fitzgen requested alexcrichton for a review on PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:24):

fitzgen requested wasmtime-core-reviewers for a review on PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 08 2025 at 18:28):

fitzgen has enabled auto merge for PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 19:12):

fitzgen updated PR #11408.

Wasmtime GitHub notifications bot (Aug 08 2025 at 19:47):

fitzgen merged PR #11408.

Last updated: Dec 06 2025 at 07:03 UTC