Wasmtime GitHub notifications bot (Aug 08 2025 at 16:31): Wasmtime GitHub notifications bot (Aug 08 2025 at 16:31):alexcrichton opened PR #11405 from alexcrichton:naked-asm to bytecodealliance:main:
This deletes our home-grown
asm_func!macro in favor of using#[unsafe(naked)]functions within Wasmtime. This is needed for fiber-related bits right now where we need tight control over the exact assembly of some functions. This additionally migrates s390x fiber bits to Rust as inline assembly is now stable for s390x.prtest:full
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 08 2025 at 16:31):alexcrichton edited PR #11405:
This deletes our home-grown
asm_func!macro in favor of using#[unsafe(naked)]functions within Wasmtime. This is needed for fiber-related bits right now where we need tight control over the exact assembly of some functions. This additionally migrates s390x fiber bits to Rust as inline assembly is now stable for s390x.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 08 2025 at 16:32):alexcrichton commented on PR #11405:
I'll note that this is a draft PR because naked functions are in Rust 1.88 which is not in our MSRV yet, but I wanted to see if things worked out ahead of time.
Wasmtime GitHub notifications bot (Aug 08 2025 at 16:36):alexcrichton updated PR #11405.
Wasmtime GitHub notifications bot (Aug 08 2025 at 17:04):fitzgen commented on PR #11405:
This additionally migrates s390x fiber bits to Rust as inline assembly is now stable for s390x.
Is this also part of 1.88? If not, then it seems worth it to split out into a PR that can land earlier.
Wasmtime GitHub notifications bot (Aug 08 2025 at 17:47):alexcrichton commented on PR #11405:
It's possible yeah, but personally I'm content to wait for a release myself
Wasmtime GitHub notifications bot (Sep 18 2025 at 16:57):alexcrichton updated PR #11405.
Wasmtime GitHub notifications bot (Sep 18 2025 at 17:25):alexcrichton has marked PR #11405 as ready for review.
Wasmtime GitHub notifications bot (Sep 18 2025 at 17:25):alexcrichton requested wasmtime-core-reviewers for a review on PR #11405.
Wasmtime GitHub notifications bot (Sep 18 2025 at 17:25):alexcrichton requested dicej for a review on PR #11405.
Wasmtime GitHub notifications bot (Sep 18 2025 at 17:25):alexcrichton requested wasmtime-default-reviewers for a review on PR #11405.
Wasmtime GitHub notifications bot (Sep 18 2025 at 17:25):alexcrichton commented on PR #11405:
Good to go now!
Wasmtime GitHub notifications bot (Sep 18 2025 at 20:18):dicej submitted PR review.
Wasmtime GitHub notifications bot (Sep 18 2025 at 20:47):alexcrichton merged PR #11405.
Last updated: Dec 06 2025 at 06:05 UTC