Stream: git-wasmtime

Topic: wasmtime / PR #11376 CacheConfigs are always enabled; cla...

Wasmtime GitHub notifications bot (Aug 04 2025 at 14:11):

jder opened PR #11376 from jder:cache-tweaks to bytecodealliance:main:

This makes two small changes to the CacheConfig/Cache system:

First, the comments referred to enabled/disabled caches, which is no longer a thing after https://github.com/bytecodealliance/wasmtime/pull/10665, so I've removed this. There were also some docs about panics in these cases (which are also now impossible) which I removed.

Second, CacheConfig::default()/CacheConfig::new() produced configs which would panic if you asked for their directory without first calling validate, but validate is not public API. So instead we return an Option from CacheConfig::directory() and move the panic to Cache::directory() and WorkerThread::directory() which should be impossible to trigger (since validate is called by Cache::new). We could alternatively make a ValidatedCacheConfig or something which is returned from validate and store/pass that around, but it seemed a bit overkill to me.

cc @benbrandt who was working on this recently in case I'm missing something.

Wasmtime GitHub notifications bot (Aug 04 2025 at 14:11):

jder requested alexcrichton for a review on PR #11376.

Wasmtime GitHub notifications bot (Aug 04 2025 at 14:11):

jder requested wasmtime-core-reviewers for a review on PR #11376.

Wasmtime GitHub notifications bot (Aug 04 2025 at 14:50):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Aug 04 2025 at 15:48):

github-actions[bot] commented on PR #11376:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Aug 04 2025 at 15:53):

alexcrichton merged PR #11376.

Last updated: Dec 06 2025 at 06:05 UTC