Stream: git-wasmtime

Topic: wasmtime / PR #11357 move waitable to original set after ...

Wasmtime GitHub notifications bot (Jul 30 2025 at 22:59):

dicej requested alexcrichton for a review on PR #11357.

Wasmtime GitHub notifications bot (Jul 30 2025 at 22:59):

dicej opened PR #11357 from dicej:move-waitables-back to bytecodealliance:main:

There are a few places in concurrent.rs where we use GuestTask::sync_call_set to wait on waitables during synchronous calls. However, they may have been members of another set before we joined them to sync_call_set, in which case we need to move them back when we're done (or at least remove them from sync_call_set).

Prior to this fix, we would panic when dropping a task which had subtasks which had been synchronously cancelled. I've updated async_cancel_callee.rs to cover that case.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 30 2025 at 22:59):

dicej requested wasmtime-core-reviewers for a review on PR #11357.

Wasmtime GitHub notifications bot (Jul 30 2025 at 23:01):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2025 at 23:01):

alexcrichton has enabled auto merge for PR #11357.

Wasmtime GitHub notifications bot (Jul 30 2025 at 23:37):

alexcrichton merged PR #11357.

Last updated: Dec 06 2025 at 06:05 UTC