Stream: git-wasmtime

Topic: wasmtime / PR #11356 Create `ir::Signature`s on a per-`Mo...

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:32):

fitzgen opened PR #11356 from fitzgen:dedupe-ir-signatures-in-translation to bytecodealliance:main:

Not on a per TypeIndex basis. The former is deduplicated, the latter is not. This way we don't end up creating duplicate ir::Signatures in the CLIF.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:32):

fitzgen requested alexcrichton for a review on PR #11356.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:32):

fitzgen requested wasmtime-core-reviewers for a review on PR #11356.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:32):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #11356.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:33):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:33):

fitzgen created PR review comment:

FWIW, I did check that without the rest of this commit, this test case produces duplicate ir::Signatures given this input.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:33):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:33):

fitzgen created PR review comment:

That is, this test fails without the rest of the commit.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:34):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:35):

fitzgen has enabled auto merge for PR #11356.

Wasmtime GitHub notifications bot (Jul 30 2025 at 22:55):

fitzgen merged PR #11356.

Last updated: Dec 06 2025 at 06:05 UTC