Stream: git-wasmtime

Topic: wasmtime / PR #11355 Take typed Wasm indices in `FuncTran...

Wasmtime GitHub notifications bot (Jul 30 2025 at 20:23):

fitzgen opened PR #11355 from fitzgen:func-translation-state-typed-indices to bytecodealliance:main:

These methods get-or-create various entities given some kind of Wasm index. Those Wasm indices were previously passed as u32s, but are now typed indices (e.g. MemoryIndex instead of u32). This makes it more difficult to pass the wrong index to these methods.

I also removed some unused arguments from a few FuncEnvironment methods that the results of FuncTranslationState::get_* calls were feeding into. These were left over from when FuncEnvironment was a trait and not a single type.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 30 2025 at 20:23):

fitzgen requested abrown for a review on PR #11355.

Wasmtime GitHub notifications bot (Jul 30 2025 at 20:23):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #11355.

Wasmtime GitHub notifications bot (Jul 30 2025 at 20:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:22):

fitzgen merged PR #11355.

Last updated: Dec 06 2025 at 06:05 UTC