Stream: git-wasmtime

Topic: wasmtime / PR #11354 Refine `Guard*` APIs and implementa...

Wasmtime GitHub notifications bot (Jul 30 2025 at 19:58):

alexcrichton opened PR #11354 from alexcrichton:refactor-guards to bytecodealliance:main:

This is a follow-up to https://github.com/bytecodealliance/wasmtime/pull/11325 with a number of cosmetic changes about
the shape of the API and structure of the internals:

• {Stream,Future}{Reader,Writer}::guard is now an alternative
  constructor to Guard*::new (import fewer types).

• Internally WithAccessor and DropWithStore are removed in favor of
  direct Drop for Guard* impls.

• An Option is used to replace ManuallyDrop and unsafe code.

• {Stream,Future}{Reader,Writer}::close{,_with} now take &mut self
  instead of self to be more composable with &mut self arguments
  during Drop for other structures (e.g. build-your-own
  drop-with-store).

• The type parameters on Guard* are simplified to just T, the future
  or stream payload, and A: AsAccessor. This helps cut down on the
  complexity of signatures.

• Guard* types now have into_{stream,future} as an alternative to
  .into() which doesn't require type annotations.

Wasmtime GitHub notifications bot (Jul 30 2025 at 19:58):

alexcrichton requested pchickey for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 19:58):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 19:58):

alexcrichton requested dicej for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 19:59):

alexcrichton commented on PR #11354:

I'll note the first commit here is from https://github.com/bytecodealliance/wasmtime/pull/11351, so only the second commit is for this PR

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:19):

alexcrichton requested fitzgen for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:19):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:19):

alexcrichton requested wasmtime-wasi-reviewers for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:19):

alexcrichton requested wasmtime-default-reviewers for a review on PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:19):

alexcrichton updated PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:41):

fitzgen submitted PR review:

LGTM, although I am not super familiar with this code

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:42):

alexcrichton updated PR #11354.

Wasmtime GitHub notifications bot (Jul 30 2025 at 21:42):

alexcrichton edited a comment on PR #11354:

I'll note the first commit here is from https://github.com/bytecodealliance/wasmtime/pull/11351, so only the second commit is for this PR EDIT: prereqs landed

Wasmtime GitHub notifications bot (Jul 31 2025 at 13:56):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jul 31 2025 at 14:45):

alexcrichton merged PR #11354.

Last updated: Dec 06 2025 at 07:03 UTC