Wasmtime GitHub notifications bot (Jul 30 2025 at 18:53): Wasmtime GitHub notifications bot (Jul 30 2025 at 18:53):alexcrichton requested dicej for a review on PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 18:53):alexcrichton opened PR #11351 from alexcrichton:no-fallible-drop to bytecodealliance:main:
This commit is a refinement of #11325 to use
.unwrap()internally instead of ignoring errors from dropping futures and streams. Fallible drop isn't supported in Rust and these shouldn't panic assuming the host is properly matching handles to stores.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 30 2025 at 18:53):alexcrichton requested wasmtime-core-reviewers for a review on PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 18:59):dicej submitted PR review.
Wasmtime GitHub notifications bot (Jul 30 2025 at 19:57):alexcrichton requested wasmtime-wasi-reviewers for a review on PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 19:57):alexcrichton updated PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 19:57):alexcrichton has enabled auto merge for PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 20:54):alexcrichton requested cfallin for a review on PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 20:54):alexcrichton requested wasmtime-default-reviewers for a review on PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 20:54):alexcrichton updated PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 21:02):dicej submitted PR review.
Wasmtime GitHub notifications bot (Jul 30 2025 at 21:04):alexcrichton updated PR #11351.
Wasmtime GitHub notifications bot (Jul 30 2025 at 21:40):alexcrichton merged PR #11351.
Last updated: Dec 06 2025 at 06:05 UTC