Stream: git-wasmtime

Topic: wasmtime / PR #11343 Add `cargo install` and `cargo bin...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 00:19):

veralvx edited PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 16:11):

fitzgen submitted PR review:

Thanks! Looks good to me with the following minor tweaks applied.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 16:11):

fitzgen created PR review comment:

Another very small nitpick: s/wasmtime/Wasmtime/ or s/wasmtime/wasmtime/.

Probably the latter, since we are talking about the CLI tool specifically here and not The Wasmtime Project.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 16:11):

fitzgen created PR review comment:

Tiny tweak to clarify why one might use cargo install instead of downloading binaries or cloning and building from source:

If you have [Rust and Cargo](https://www.rust-lang.org/tools/install) available in your system, you can build and install an official `wasmtime` release from its [crates.io](https://crates.io/crates/wasmtime-cli) source:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 16:11):

fitzgen created PR review comment:

Can you add like a half sentence that explains why one might use binstall? As-is, readers who are not familiar with it will be left wondering why this extra option is provided.

Maybe something like the following?

You can also use [`cargo binstall`](https://github.com/cargo-bins/cargo-binstall) to automatically find and install the correct `wasmtime` binary for your system:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:30):

veralvx updated PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:35):

veralvx updated PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:37):

veralvx submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:37):

veralvx created PR review comment:

I appreciate your suggestions. I added this to a new commit, while also adding that cargo binstall finds a candidate from the Github Releases page

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:39):

veralvx submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:39):

veralvx created PR review comment:

Correct, I thought of the wasmtime cli tool.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:42):

veralvx updated PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:43):

veralvx edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:54):

veralvx updated PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 17:58):

veralvx updated PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 18:05):

fitzgen submitted PR review:

Looks great, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 18:05):

fitzgen has enabled auto merge for PR #11343.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2025 at 18:35):

fitzgen merged PR #11343.

Last updated: Dec 06 2025 at 06:05 UTC