Stream: git-wasmtime

Topic: wasmtime / PR #11338 Fix calculation of reachable DWARF


view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2025 at 05:36):

philipc opened PR #11338 from philipc:dwarf-reachable to bytecodealliance:main:

A single dependency graph indexed by gimli::UnitSectionOffset was used to contain the dependencies from every gimli::Dwarf. However, this is not correct because a gimli::UnitSectionOffset is only unique within its associated gimli::Dwarf.

Fix by using one graph per gimli::Dwarf.

In addition to wasmtime's tests, the only testing I have done on this is to compile the component-docs tutorial using wasmtime and diff the resulting DWARF. That diff showed that this patch does affect which DWARF entries are determined to be reachable.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2025 at 05:36):

philipc requested alexcrichton for a review on PR #11338.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2025 at 05:36):

philipc requested wasmtime-compiler-reviewers for a review on PR #11338.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2025 at 14:30):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2025 at 14:57):

alexcrichton merged PR #11338.


Last updated: Dec 06 2025 at 06:05 UTC