philipc opened PR #11338 from philipc:dwarf-reachable to bytecodealliance:main:
A single dependency graph indexed by
gimli::UnitSectionOffsetwas used to contain the dependencies from everygimli::Dwarf. However, this is not correct because agimli::UnitSectionOffsetis only unique within its associatedgimli::Dwarf.Fix by using one graph per
gimli::Dwarf.In addition to wasmtime's tests, the only testing I have done on this is to compile the component-docs tutorial using wasmtime and diff the resulting DWARF. That diff showed that this patch does affect which DWARF entries are determined to be reachable.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
philipc requested alexcrichton for a review on PR #11338.
philipc requested wasmtime-compiler-reviewers for a review on PR #11338.
alexcrichton submitted PR review:
Thanks!
alexcrichton merged PR #11338.
Last updated: Dec 06 2025 at 06:05 UTC