Stream: git-wasmtime

Topic: wasmtime / PR #11329 Notify on-screen instructions need t...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 11:20):

hashimoto-kei edited PR #11329.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 11:29):

hashimoto-kei commented on PR #11329:

Thank you for your feedback.

As you said, it is not better for README to notify specific instructions, but better for the install script to print specific instructions.

This fixes README to notify users should follow the on-screen instructions printed by the install script.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 11:35):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedback.

As you said, it is not better for README to notify specific instructions, but better for the install script to print specific instructions.

This fixes README to notify users should follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 11:36):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

As you said, it is not better for README to notify specific instructions, but better for the install script to print specific instructions.

This fixes README to notify users should follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 11:38):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

As you said, it is not better for README to notify specific instructions, but better for the install script to print specific instructions.

README notifies users should follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 15:07):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

As you said, it is better for the install script to print specific instructions.
(And it is not good for README to notify specific instructions.)

In this fix, README only tells users to follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 15:13):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

As you said, it is better for the install script to print specific instructions.
(And it is not good for README to notify specific instructions.)

So I changed the message to follow on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2025 at 15:13):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

As you said, it is better for the install script to print specific instructions.
(And it is not good for README to notify specific instructions.)

So I changed the message to follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2025 at 04:05):

hashimoto-kei edited a comment on PR #11329:

Thank you for your feedbacks.

I changed the message to follow the on-screen instructions printed by the install script.

FYI, I referenced the following.
https://github.com/bytecodealliance/wasmtime.dev/blob/481a3aee5b86617b499274452dda34fe928fd7b0/index.md?plain=1#L40-L41

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2025 at 22:01):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2025 at 22:26):

pchickey merged PR #11329.

Last updated: Dec 06 2025 at 07:03 UTC