Wasmtime GitHub notifications bot (Jul 24 2025 at 17:00): Wasmtime GitHub notifications bot (Jul 24 2025 at 17:00):fitzgen opened PR #11316 from fitzgen:tidy-table-copy-raw to bytecodealliance:main:
The
matchmakes the cases a lot more clear IMO, and additionally the conditions asserted in each branch become trivially obvious (they are exactly what was matched upon for their associated branch) so I removed them.I also made some minor copy-edit tweaks to some comments while I was here.
This would have just been a nitpick review comment on https://github.com/bytecodealliance/wasmtime/pull/11255 but I was traveling and didn't get a chance to leave review comments in a reasonable amount of time, so instead I am just fixing them up myself in this follow up.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 24 2025 at 17:00):fitzgen requested wasmtime-core-reviewers for a review on PR #11316.
Wasmtime GitHub notifications bot (Jul 24 2025 at 17:00):fitzgen requested pchickey for a review on PR #11316.
Wasmtime GitHub notifications bot (Jul 24 2025 at 17:23):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 24 2025 at 17:46):alexcrichton merged PR #11316.
Last updated: Dec 06 2025 at 07:03 UTC