Stream: git-wasmtime

Topic: wasmtime / PR #11293 Fix linker warnings on macOS

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2025 at 03:18):

xiaozhuai edited PR #11293.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2025 at 04:56):

xiaozhuai commented on PR #11293:

Sure, I've modified this PR.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2025 at 14:32):

alexcrichton commented on PR #11293:

Oh sorry I meant deleting the code in examples/CMakeLists.txt rather than here. The additions you had here in this PR looked correct to me and my comment was about how the similar linking directive in examples/CMakeLists.txt were redundant (or at least I think they were).

In the meantime this all looks good to me so I'll flag it for merge, but if you'd like I'd be happy to merge a PR with the changes of linking to CoreFoundation

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2025 at 14:32):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2025 at 14:57):

alexcrichton merged PR #11293.

Last updated: Dec 06 2025 at 07:03 UTC