Wasmtime GitHub notifications bot (Jul 18 2025 at 22:55): Wasmtime GitHub notifications bot (Jul 18 2025 at 22:55):fitzgen opened PR #11282 from fitzgen:inlining-unreachable-blocks to bytecodealliance:main:
We copy all callee blocks into the caller's layout, but were then only copying the callee instructions in reachable callee blocks into the caller. Therefore, any unreachable blocks would remain empty in the caller, which is invalid CLIF because all blocks must end in a terminator, so this commit adds a quick pass over the inlined blocks to remove any empty blocks from the caller's layout.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 18 2025 at 22:55):fitzgen requested alexcrichton for a review on PR #11282.
Wasmtime GitHub notifications bot (Jul 18 2025 at 22:55):fitzgen requested wasmtime-compiler-reviewers for a review on PR #11282.
Wasmtime GitHub notifications bot (Jul 22 2025 at 19:05):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 22 2025 at 21:14):alexcrichton merged PR #11282.
Last updated: Dec 06 2025 at 06:05 UTC