Stream: git-wasmtime

Topic: wasmtime / PR #11259 Rename `Instance::run_with` to `Inst...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 19:38):

alexcrichton requested dicej for a review on PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 19:38):

alexcrichton opened PR #11259 from alexcrichton:rename-run-concurrent to bytecodealliance:main:

This commit renames run_with to run_concurrent and additionally deletes the Instance::run method. With Accessor-related changes there's no need to have a "just run with a future" method as almost everything is going to require run_concurrent anyway to acquire an accessor.

Closes #11224

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 19:38):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 19:49):

alexcrichton updated PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 19:49):

alexcrichton requested wasmtime-wasi-reviewers for a review on PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 21:30):

dicej submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 21:30):

dicej created PR review comment:

    /// explicitly call `Func::post_return` afterward.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 21:33):

alexcrichton updated PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 21:33):

alexcrichton has enabled auto merge for PR #11259.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2025 at 22:11):

alexcrichton merged PR #11259.


Last updated: Dec 06 2025 at 06:05 UTC