Stream: git-wasmtime

Topic: wasmtime / PR #11244 fix(wasmtime): fix `--no-default-fea...

Wasmtime GitHub notifications bot (Jul 15 2025 at 15:10):

rvolosatovs opened PR #11244 from rvolosatovs:fix/component-model-async-features to bytecodealliance:main:

Currently, building wasmtime via:

$ cargo build -p wasmtime --no-default-features --features component-model-async

fails with:

error[E0432]: unresolved import `wasmtime_environ::fact`
  --> crates/wasmtime/src/runtime/component/concurrent.rs:88:36
   |
88 | use wasmtime_environ::{PrimaryMap, fact};
   |                                    ^^^^ no `fact` in the root
   |
note: found an item that was configured out
  --> /Users/rvolosatovs/src/github.com/bytecodealliance/wasmtime/crates/environ/src/lib.rs:72:9
   |
72 | pub mod fact;
   |         ^^^^
note: the item is gated here
  --> /Users/rvolosatovs/src/github.com/bytecodealliance/wasmtime/crates/environ/src/lib.rs:71:1
   |
71 | #[cfg(all(feature = "component-model", feature = "compile"))]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

in order to avoid the need for component-model-async feature to enable wasmtime-environ/compile, promote START_FLAG_ASYNC_CALLEE to crate-level const

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 15 2025 at 15:10):

rvolosatovs requested alexcrichton for a review on PR #11244.

Wasmtime GitHub notifications bot (Jul 15 2025 at 15:10):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #11244.

Wasmtime GitHub notifications bot (Jul 15 2025 at 15:43):

rvolosatovs assigned rvolosatovs to PR #11244.

Wasmtime GitHub notifications bot (Jul 15 2025 at 16:11):

alexcrichton created PR review comment:

Mind moving this to component.rs? There's a few other constants in there as well so I think it'd fit well there.

Wasmtime GitHub notifications bot (Jul 15 2025 at 16:11):

alexcrichton submitted PR review:

Thanks! Mind adding a check for this on CI as well? (e.g. the micro_checks job)

Wasmtime GitHub notifications bot (Jul 15 2025 at 16:23):

rvolosatovs requested badeend for a review on PR #11244.

Wasmtime GitHub notifications bot (Jul 15 2025 at 16:23):

rvolosatovs requested wasmtime-default-reviewers for a review on PR #11244.

Wasmtime GitHub notifications bot (Jul 15 2025 at 16:23):

rvolosatovs updated PR #11244 (assigned to rvolosatovs).

Wasmtime GitHub notifications bot (Jul 15 2025 at 17:53):

rvolosatovs merged PR #11244.

Last updated: Dec 06 2025 at 06:05 UTC