Stream: git-wasmtime

Topic: wasmtime / PR #11216 Delete `vm::Instance::table_grow`


view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 01:24):

alexcrichton opened PR #11216 from alexcrichton:remove-vm-table-grow to bytecodealliance:main:

This commit is a further inch towards #11179 by removing internal reliance on reading VMContext pointers and casting them to Pin<&mut Instance> in various contexts. Notably now only a defined table needs to be grown, which simplifies the internals of vm::Instance ever so slightly. This is a similar change as #11211 which transitions libcalls to using DefinedTableIndex instead of TableIndex.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 01:24):

alexcrichton requested abrown for a review on PR #11216.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 01:24):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11216.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 01:24):

alexcrichton requested fitzgen for a review on PR #11216.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 01:24):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11216.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 04:02):

github-actions[bot] commented on PR #11216:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 15:34):

fitzgen submitted PR review:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2025 at 15:56):

fitzgen merged PR #11216.


Last updated: Dec 06 2025 at 07:03 UTC