Stream: git-wasmtime

Topic: wasmtime / PR #11207 Cranelift: Make `ir::{Constant,Immed...

Wasmtime GitHub notifications bot (Jul 09 2025 at 18:33):

fitzgen opened PR #11207 from fitzgen:ir-constant-immediate-entities to bytecodealliance:main:

They reference data in out-of-line pools rather than storing their data inline in the instruction, and when an instruction containing them is moved from one ir::Function to another, they need their indices updated accordingly. Therefore, they really are entities rather than immediates.

This recategorization means that they will now be properly mapped in ir::InstructionData::map calls.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 09 2025 at 18:33):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #11207.

Wasmtime GitHub notifications bot (Jul 09 2025 at 18:33):

fitzgen requested cfallin for a review on PR #11207.

Wasmtime GitHub notifications bot (Jul 09 2025 at 18:44):

fitzgen updated PR #11207.

Wasmtime GitHub notifications bot (Jul 09 2025 at 18:45):

fitzgen commented on PR #11207:

(Why we have both ir::Constant and ir::Immediate is not 100% clear to me, seems like we could probably clean this up so that we just have ir::Constant, but that is future work.)

Wasmtime GitHub notifications bot (Jul 09 2025 at 19:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 09 2025 at 19:47):

cfallin merged PR #11207.

Last updated: Dec 06 2025 at 06:05 UTC