Wasmtime GitHub notifications bot (Jul 07 2025 at 21:28): Wasmtime GitHub notifications bot (Jul 07 2025 at 21:28):alexcrichton opened PR #11196 from alexcrichton:x64-jcc to bytecodealliance:main:
While this doesn't remove any pseudo insts from ISLE (as was thought might be the case with
WinchJmpIf) this does clean up some emission code to use some helpers and make it more clear what's happening.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 07 2025 at 21:28):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11196.
Wasmtime GitHub notifications bot (Jul 07 2025 at 21:28):alexcrichton requested fitzgen for a review on PR #11196.
Wasmtime GitHub notifications bot (Jul 09 2025 at 15:31):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2025 at 15:31):fitzgen created PR review comment:
Does it make sense to generate helper functions or something for these aliases? Obviously not necessary in this PR, but something to think about.
Wasmtime GitHub notifications bot (Jul 09 2025 at 18:32):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2025 at 18:32):alexcrichton created PR review comment:
Good point! cc @abrown on this as well about maybe adding "aliases" or such to the assembler. AFAIK it's just anything related to condition codes though which may not be worth the feature too
Wasmtime GitHub notifications bot (Jul 09 2025 at 18:54):alexcrichton merged PR #11196.
Last updated: Dec 06 2025 at 06:05 UTC