Stream: git-wasmtime

Topic: wasmtime / PR #11195 Enable `allow_attributes_without_rea...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:18):

alexcrichton opened PR #11195 from alexcrichton:wasmtime-lint-reasons to bytecodealliance:main:

This commit enables the clippy::allow_attributes_without_reason for the wasmtime crate which previously forcibly allowed it. The reason this was allowed was that when the workspace was first migrated the Wasmtime crate had too many instances that I was willing to fix. I've now come back around and tried to fix everything.

In short: ideally delete #[allow], otherwise use #[expect], otherwise use #[allow].

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:18):

alexcrichton requested fitzgen for a review on PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:18):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:20):

alexcrichton updated PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:22):

alexcrichton updated PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:34):

alexcrichton updated PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 20:43):

alexcrichton updated PR #11195.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 21:50):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 22:13):

alexcrichton merged PR #11195.


Last updated: Dec 06 2025 at 06:05 UTC