Stream: git-wasmtime

Topic: wasmtime / PR #11186 Couple of optimizations to the Crane...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:32):

bjorn3 opened PR #11186 from bjorn3:optimize_cranelift_cache to bytecodealliance:main:

Fixes https://github.com/bytecodealliance/wasmtime/issues/11134

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:32):

bjorn3 requested abrown for a review on PR #11186.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:32):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #11186.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:33):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:33):

bjorn3 created PR review comment:

This is necessary to due to the change to using SecondaryMap for ValueLabelsRanges.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 11:38):

bjorn3 updated PR #11186.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 12:25):

bjorn3 updated PR #11186.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 12:25):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 17:38):

abrown created PR review comment:

I wondered if there was a way to avoid exposing the internal byte representation but pub(crate) isn't an option so it's not clear what else would work. If you're happy with this then let's leave it as is.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 17:38):

abrown submitted PR review:

This makes sense. I'll wait to hear if you have any opinions about protecting the internal bit representation before merging.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2025 at 17:38):

abrown created PR review comment:

But maybe an IsaFlags([u8]) with impl Hash could work...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2025 at 13:58):

bjorn3 updated PR #11186.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2025 at 13:58):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2025 at 13:58):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2025 at 16:33):

abrown merged PR #11186.

Last updated: Dec 06 2025 at 06:05 UTC