Wasmtime GitHub notifications bot (Jun 25 2025 at 22:02): Wasmtime GitHub notifications bot (Jun 25 2025 at 22:02):jlb6740 opened PR #11135 from jlb6740:add-shuf-to-new-assembler to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:02):jlb6740 requested wasmtime-compiler-reviewers for a review on PR #11135.
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:02):jlb6740 requested cfallin for a review on PR #11135.
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:04):jlb6740 submitted PR review.
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:04):jlb6740 created PR review comment:
Note I've added support for shufpd and vshufpd but these instructions did not exist before. Assembler testing passes but there is no filetest and I'd guess this is just dead code. Should I just remove these instructions?
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:06):cfallin submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:06):cfallin created PR review comment:
Since there is separately the Capstone-based fuzzing for the assembler, I think it's probably fine to fill things out like this where it's not much extra work, and it might be nice to have (this library at least aspires to be a separately usable general-purpose assembler someday, right?).
Wasmtime GitHub notifications bot (Jun 25 2025 at 22:07):cfallin commented on PR #11135:
It looks like there are some merge conflicts -- happy to merge once those are fixed.
Wasmtime GitHub notifications bot (Jun 26 2025 at 00:50):jlb6740 updated PR #11135.
Wasmtime GitHub notifications bot (Jun 26 2025 at 16:25):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 26 2025 at 16:25):abrown created PR review comment:
@jlb6740 , somehow this is added now and it shouldn't be. This is never used right?
Wasmtime GitHub notifications bot (Jun 26 2025 at 19:07):jlb6740 created PR review comment:
Ohh .. yes, thanks. I noticed in some other PRs that the avx version was still listed here for instructions that had been updated and I wasn't sure if that was just an omission or if it needed to remain. I'll remove, but I think there are others that ar never used that need to be removed as well.
Wasmtime GitHub notifications bot (Jun 26 2025 at 19:07):jlb6740 submitted PR review.
Wasmtime GitHub notifications bot (Jun 26 2025 at 19:09):jlb6740 deleted PR review comment.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:22):jlb6740 submitted PR review.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:22):jlb6740 created PR review comment:
I added this because vshufpd is a new instruction that wasn't supported before. Adding it makes it consistent with what is there now. It seems we've kept this AVX enum intact here and here: cranelift/codegen/src/isa/x64/inst/args.rs . Perhaps we are able too delete these avx instructions from both these files but vshufpd wouldn't be the only one .. pack, align, insert, phadd, etc all would need removing and so perhaps we can do that all at once?
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:22):jlb6740 updated PR #11135.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:22):jlb6740 edited PR review comment.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:26):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:26):abrown created PR review comment:
There is no
Vshufpdonmain:The
args.rsfile is just reflecting this list and it is not there either. I'm not sure I follow why you think it should be added, but we shouldn't, since I am in the process of removing this entire thing.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:53):jlb6740 updated PR #11135.
Wasmtime GitHub notifications bot (Jun 26 2025 at 21:54):abrown has enabled auto merge for PR #11135.
Wasmtime GitHub notifications bot (Jun 26 2025 at 22:29):abrown merged PR #11135.
Last updated: Dec 06 2025 at 07:03 UTC