Wasmtime GitHub notifications bot (Jun 23 2025 at 19:38): Wasmtime GitHub notifications bot (Jun 23 2025 at 19:38):alexcrichton opened PR #11112 from alexcrichton:x64-setcc to bytecodealliance:main:
These instructions were relatively straightforward and the notable parts here are:
The manual doesn't have
/0but these instructions use.digit(0), but the manual also says the reg bits are ignored in the ModR/M byte so it doesn't actually matter what we put in these bits, just need to put something in there.The previous implementation in
emit.rsunconditionally emitted a REX byte but this was not necessary for some registers, so many binary offsets have changed in tests as some unnecessary REX bytes are now omitted.As with
cmov*instructions in #11095 some mnemonics that Cranelift uses differ from the canonical ones that Capstone disassembles, so there are some naming discrepancies which are documented inline as well.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 23 2025 at 19:38):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11112.
Wasmtime GitHub notifications bot (Jun 23 2025 at 19:38):alexcrichton requested fitzgen for a review on PR #11112.
Wasmtime GitHub notifications bot (Jun 23 2025 at 19:38):alexcrichton requested wasmtime-core-reviewers for a review on PR #11112.
Wasmtime GitHub notifications bot (Jun 24 2025 at 14:57):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 24 2025 at 15:24):alexcrichton updated PR #11112.
Wasmtime GitHub notifications bot (Jun 24 2025 at 15:24):alexcrichton has enabled auto merge for PR #11112.
Wasmtime GitHub notifications bot (Jun 24 2025 at 15:47):alexcrichton has disabled auto merge for PR #11112.
Wasmtime GitHub notifications bot (Jun 24 2025 at 16:02):alexcrichton merged PR #11112.
Last updated: Dec 06 2025 at 06:05 UTC