Stream: git-wasmtime

Topic: wasmtime / PR #11095 x64: Migrate `cmov*` to the new asse...

Wasmtime GitHub notifications bot (Jun 21 2025 at 00:30):

alexcrichton opened PR #11095 from alexcrichton:x64-cmov to bytecodealliance:main:

This commit adds all cmov* variants from the Intel manual to the new assembler. This then additionally removes the Cmove pseudo-inst in favor of these new instructions. One difference from before is that the naming in the CC enum does not exactly match what mnemonics Capstone uses to disassemble. For example CC.NB in ISLE corresponds to the Intel instruction CMOVNB. This instruction, however, has the same encoding as CMOVAE and Capstone disassembles as CMOVAE. This means that the instruction selection in ISLE isn't a 1:1 match with mnemonics.

This additionally adds support in the assembler ISLE generation to understand that instructions which read EFLAGS generate a ConsumesFlags variant in their instruction helpers.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 21 2025 at 00:30):

alexcrichton requested fitzgen for a review on PR #11095.

Wasmtime GitHub notifications bot (Jun 21 2025 at 00:30):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11095.

Wasmtime GitHub notifications bot (Jun 21 2025 at 00:41):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 21 2025 at 03:06):

github-actions[bot] commented on PR #11095:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 21 2025 at 19:33):

alexcrichton merged PR #11095.

Last updated: Dec 06 2025 at 06:05 UTC