Stream: git-wasmtime

Topic: wasmtime / PR #11084 x64: Migrate `lea` to the new assem...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton opened PR #11084 from alexcrichton:x64-shrink to bytecodealliance:main:

This PR has two commits which culminate in migrating lea to the new assembler. The main trickiness about lea is that we lower all iadd nodes to lea but rely on an optimization to turn lea back into add where possible. The first commit here adds infrastructure to use the results of register allocation to refine instruction selection and then the lea commit builds on top of that and uses it. There are a few other examples of using the results of register allocation such as AND RAX, imm32 which ISLE never otherwise generates but can be selected after register allocation for a slightly more compact encoding.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton requested cfallin for a review on PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton requested dicej for a review on PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 22:53):

alexcrichton requested abrown for a review on PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 23:25):

alexcrichton updated PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 18:04):

abrown submitted PR review:

Nice! It looks like there are small code-size wins everywhere and there are probably opportunities for more of this kind of micro-optimization as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 20:03):

alexcrichton updated PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 20:03):

alexcrichton has enabled auto merge for PR #11084.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 20:40):

alexcrichton merged PR #11084.

Last updated: Dec 06 2025 at 06:05 UTC