Stream: git-wasmtime

Topic: wasmtime / PR #11081 Improve debug formatting for primary...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:20):

simvux opened PR #11081 from simvux:main to bytecodealliance:main:

Small contribution, but addresses a personal annoyance of mine.

New formatting

PrimaryMap {
    outer0: PrimaryMap {
        inner0: 0,
        inner1: 1,
    },
    outer1: PrimaryMap {
        inner0: 2,
        inner1: 3,
    },
}
PrimaryMap {
    outer0: PrimaryMap {
        inner0: Point {
            x: 0,
            y: 1,
        },
    },
    outer1: PrimaryMap {
        inner0: Point {
            x: 2,
            y: 3,
        },
    },
}
SecondaryMap {
    elems: [
        0,
        2,
    ],
    default: 0,
}

Previous formatting

PrimaryMap {
    elems: [
        PrimaryMap {
            elems: [
                0,
                1,
            ],
            unused: PhantomData<temp::InnerKey>,
        },
        PrimaryMap {
            elems: [
                2,
                3,
            ],
            unused: PhantomData<temp::InnerKey>,
        },
    ],
    unused: PhantomData<temp::OuterKey>,
}
PrimaryMap {
    elems: [
        PrimaryMap {
            elems: [
                Point {
                    x: 0,
                    y: 1,
                },
            ],
            unused: PhantomData<temp::InnerKey>,
        },
        PrimaryMap {
            elems: [
                Point {
                    x: 2,
                    y: 3,
                },
            ],
            unused: PhantomData<temp::InnerKey>,
        },
    ],
    unused: PhantomData<temp::OuterKey>,
}
SecondaryMap {
    elems: [
        0,
        2,
    ],
    default: 0,
    unused: PhantomData<temp::InnerKey>,
}

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:20):

simvux requested wasmtime-compiler-reviewers for a review on PR #11081.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:20):

simvux requested cfallin for a review on PR #11081.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:22):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:22):

bjorn3 created PR review comment:

Doesn't format!() work?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:23):

simvux updated PR #11081.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:24):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:24):

bjorn3 created PR review comment:

        for (k, v) in self {

should work too, right? IntoIterator is implemented for &PrimaryMap.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 19 2025 at 19:26):

simvux updated PR #11081.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 02:48):

cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 03:09):

cfallin merged PR #11081.


Last updated: Jan 09 2026 at 13:15 UTC