Stream: git-wasmtime

Topic: wasmtime / PR #11080 Add pack convert (*packss*, *packus*...

Wasmtime GitHub notifications bot (Jun 19 2025 at 19:09):

jlb6740 opened PR #11080 from jlb6740:add-packed-convert-to-new-assembler to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 19 2025 at 19:09):

jlb6740 requested wasmtime-compiler-reviewers for a review on PR #11080.

Wasmtime GitHub notifications bot (Jun 19 2025 at 19:09):

jlb6740 requested alexcrichton for a review on PR #11080.

Wasmtime GitHub notifications bot (Jun 19 2025 at 19:32):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 19 2025 at 19:32):

abrown created PR review comment:

Now that the alternate stuff is built, we can just use one rule that uses the "or_avx" ISLE rule.

Wasmtime GitHub notifications bot (Jun 19 2025 at 20:07):

jlb6740 submitted PR review.

Wasmtime GitHub notifications bot (Jun 19 2025 at 20:07):

jlb6740 created PR review comment:

Something like this:

;; Helper for creating `packsswb` instructions.
(decl x64_packsswb (Xmm XmmMem) Xmm)
(rule (x64_packsswb src1 src2) (x64_packsswb_a_or_avx src1 src2))

And it's normal that the vex version for the isle does not include an explicit destination? Just the two source operands right?

Wasmtime GitHub notifications bot (Jun 19 2025 at 20:49):

jlb6740 updated PR #11080.

Wasmtime GitHub notifications bot (Jun 20 2025 at 00:22):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 20 2025 at 00:44):

abrown merged PR #11080.

Last updated: Dec 06 2025 at 06:05 UTC