Stream: git-wasmtime

Topic: wasmtime / PR #11072 x64: Migrate cmp/test to the new ass...

Wasmtime GitHub notifications bot (Jun 19 2025 at 01:55):

alexcrichton requested abrown for a review on PR #11072.

Wasmtime GitHub notifications bot (Jun 19 2025 at 01:55):

alexcrichton opened PR #11072 from alexcrichton:x64-cmp to bytecodealliance:main:

This commit migrates the cmp and test family of instructions, the CmpRmiR variant in ISLE, to the new assembler. This required fiddling with various helpers for immediates and such throughout a few locations and refactoring various callsites of creating these instructions to fit nicely into these new idioms. EFLAGS-writing instructions with no other results are now also modeled in the assembler as ProducesFlags rather than SideEffectNoResult as their base case enabling using the generated constructors a bit more too.

No functional change is expected from this, it should just be internal refactoring.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 19 2025 at 01:55):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11072.

Wasmtime GitHub notifications bot (Jun 19 2025 at 02:10):

alexcrichton updated PR #11072.

Wasmtime GitHub notifications bot (Jun 19 2025 at 03:56):

github-actions[bot] commented on PR #11072:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 19 2025 at 13:49):

abrown submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Jun 19 2025 at 14:11):

abrown merged PR #11072.

Last updated: Dec 06 2025 at 06:05 UTC