Stream: git-wasmtime

Topic: wasmtime / PR #11068 fix: do not collect backtrace on eac...

Wasmtime GitHub notifications bot (Jun 18 2025 at 18:02):

rvolosatovs opened PR #11068 from rvolosatovs:fix/no-gc-backtrace to bytecodealliance:main:

This is something I've discovered profiling a Wasmtime embedding with wasm32-unknown-unknown modules. Currently, gc_runtime accessor returns an anyhow::Result, which triggers a backtrace collection, when gc is disabled (e.g. when gc feature is not set)

With gc feature disabled:
https://share.firefox.dev/3FTmlgN (note the anyhow::error::msg and related _Unwind_IteratePhdrCallback)

With gc, gc-null, gc-drc features enabled:
https://share.firefox.dev/3HGyEh5

To alleviate this, return an Option from the accessor, since in most cases, it's used as an Option anyway and there is only one case when error is returned when it is not set

Wasmtime GitHub notifications bot (Jun 18 2025 at 18:02):

rvolosatovs requested pchickey for a review on PR #11068.

Wasmtime GitHub notifications bot (Jun 18 2025 at 18:02):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #11068.

Wasmtime GitHub notifications bot (Jun 18 2025 at 22:35):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 18 2025 at 22:35):

alexcrichton commented on PR #11068:

Thanks!

Wasmtime GitHub notifications bot (Jun 18 2025 at 22:56):

alexcrichton merged PR #11068.

Last updated: Dec 06 2025 at 06:05 UTC