Wasmtime GitHub notifications bot (Jun 17 2025 at 09:40): Wasmtime GitHub notifications bot (Jun 17 2025 at 09:40):yanwucai opened PR #11060 from yanwucai:onnx-local-rt to bytecodealliance:main:
This change adds a new Cargo feature to allow the users to use a custom build of ONNX Runtime.
This will also help the users who need to remove some crypto-related dependencies imported by the download-binaries feature of ort.
Wasmtime GitHub notifications bot (Jun 17 2025 at 09:40):yanwucai requested wasmtime-wasi-reviewers for a review on PR #11060.
Wasmtime GitHub notifications bot (Jun 17 2025 at 14:26):alexcrichton requested abrown for a review on PR #11060.
Wasmtime GitHub notifications bot (Jun 17 2025 at 22:41):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 17 2025 at 22:41):abrown created PR review comment:
If you flip the features around, then these
#cfgs no longer need to check both cases, right?
Wasmtime GitHub notifications bot (Jun 17 2025 at 22:41):abrown created PR review comment:
What if we flipped this around?
onnxwould just havedep:ortandonnx-downloadwould bring in theort/download-binariesfeature(I'm no Cargo features expert but it does seem to conform better to the idea that they should be additive).
Wasmtime GitHub notifications bot (Jun 18 2025 at 01:58):yanwucai submitted PR review.
Wasmtime GitHub notifications bot (Jun 18 2025 at 01:58):yanwucai created PR review comment:
I am open to both options. But this would be a breaking change. If we flipped this around, existing users who are using
onnxfeature would have to switch toonnx-downloadfeature. Is this OK?
Wasmtime GitHub notifications bot (Jun 19 2025 at 16:22):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 19 2025 at 16:22):abrown created PR review comment:
I think that's ok. This is all pretty experimental at this point so having to change features for a new release seems reasonable. We can document it in the release notes.
Wasmtime GitHub notifications bot (Jun 20 2025 at 02:49):yanwucai updated PR #11060.
Wasmtime GitHub notifications bot (Jun 20 2025 at 03:00):yanwucai submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2025 at 03:00):yanwucai created PR review comment:
I flipped it around.
Wasmtime GitHub notifications bot (Jun 20 2025 at 03:00):yanwucai submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2025 at 03:00):yanwucai created PR review comment:
Yes, no need to check both cases now.
Wasmtime GitHub notifications bot (Jun 20 2025 at 15:18):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2025 at 15:50):abrown commented on PR #11060:
@yanwucai, it looks like this failure is due to some CI job that now needs the
onnx-downloadfeature enabled. Why didn't we see this earlier? Wasmtime only runs a subset of the CI jobs for a PR but runs all the CI jobs in the merge queue, including the wasi-nn jobs that failed here. If you want to run all the CI jobs in this PR to make sure things are working as intended before merge, add the textprtest:fullto the body of one of the commit messages.
Wasmtime GitHub notifications bot (Jun 23 2025 at 05:31):yanwucai updated PR #11060.
Wasmtime GitHub notifications bot (Jun 23 2025 at 05:38):yanwucai requested pchickey for a review on PR #11060.
Wasmtime GitHub notifications bot (Jun 23 2025 at 05:38):yanwucai updated PR #11060.
Wasmtime GitHub notifications bot (Jun 23 2025 at 05:38):yanwucai requested wasmtime-default-reviewers for a review on PR #11060.
Wasmtime GitHub notifications bot (Jun 23 2025 at 06:16):yanwucai commented on PR #11060:
Hi @abrown, the
onnxfeature is added back to CI in PR #11071 , I updated my branch and updated the feature. The CI jobs have passed now.
Wasmtime GitHub notifications bot (Jun 23 2025 at 13:59):abrown merged PR #11060.
Last updated: Dec 06 2025 at 06:05 UTC