Stream: git-wasmtime

Topic: wasmtime / PR #11052 Share log state amongst handles in `...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 16:36):

alexcrichton requested pchickey for a review on PR #11052.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 16:36):

alexcrichton opened PR #11052 from alexcrichton:serve-share-state-in-handles to bytecodealliance:main:

This commit fixes an issue where when multiple independent stdio handles were acquired they would share different states about whether a prefix was necessary or not which could lead to confusing output. This commit fixes the log streams of wasmtime serve to share state amongst the various handles created by putting internal state into an Arc and mutating it behind the scenes in the implementation.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 16:36):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11052.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 17:13):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 17:48):

alexcrichton updated PR #11052.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 17:48):

alexcrichton has enabled auto merge for PR #11052.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 16 2025 at 18:23):

alexcrichton merged PR #11052.


Last updated: Dec 06 2025 at 06:05 UTC