Stream: git-wasmtime

Topic: wasmtime / PR #11049 Update to WASI 0.2.6.

Wasmtime GitHub notifications bot (Jun 16 2025 at 13:40):

badeend opened PR #11049 from badeend:wasi-0.2.6 to bytecodealliance:main:

Nothing much has changed since 0.2.3, except:

• https://github.com/WebAssembly/wasi-filesystem/pull/165: Documentation update
• https://github.com/WebAssembly/wasi-http/pull/139: Adds a new unstable send-informational function to the response-outparam resource.
  • I've left this unimplemented!().
  • Since this is the first @unstable feature in the wasi-http interface, the bindgen has also generated a new LinkOptions type. Once somebody implements this method, they'll need to propagate a LinkOptions parameter up to the CLI options code.
    

Wasmtime GitHub notifications bot (Jun 16 2025 at 13:40):

badeend requested wasmtime-wasi-reviewers for a review on PR #11049.

Wasmtime GitHub notifications bot (Jun 16 2025 at 13:40):

badeend requested dicej for a review on PR #11049.

Wasmtime GitHub notifications bot (Jun 16 2025 at 13:40):

badeend requested wasmtime-default-reviewers for a review on PR #11049.

Wasmtime GitHub notifications bot (Jun 16 2025 at 13:40):

badeend requested wasmtime-core-reviewers for a review on PR #11049.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:20):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:24):

dicej submitted PR review:

Thanks for doing this! LGTM, but please see the note about panicking in send_informational.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:24):

dicej created PR review comment:

I think we should trap here rather than panic.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:26):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:26):

rvolosatovs created PR review comment:

Other modules typically define with_options counterparts, like so: https://github.com/bytecodealliance/wasmtime/blob/60269d642510263ccf5fe637c042d663fecfc43a/crates/wasi/src/p2/mod.rs#L469-L490

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:36):

badeend updated PR #11049.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:46):

badeend submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 14:46):

badeend created PR review comment:

I'm aware.
I think it makes more sense to update the public API whenever this new method actually gets implemented. Because right now, there's no reason for the consumer to use this parameter, other than to enable a method that unconditionally ~panics~ traps.

WDYT?

Wasmtime GitHub notifications bot (Jun 16 2025 at 15:06):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 18:05):

rvolosatovs created PR review comment:

Absolutely!

Wasmtime GitHub notifications bot (Jun 16 2025 at 18:05):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 18:05):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 18:30):

pchickey merged PR #11049.

Last updated: Dec 06 2025 at 07:03 UTC