Stream: git-wasmtime

Topic: wasmtime / PR #11047 Refine `VMArrayCallNative`

Wasmtime GitHub notifications bot (Jun 14 2025 at 17:38):

alexcrichton opened PR #11047 from alexcrichton:refactor-vmarraycallnative to bytecodealliance:main:

This commit refines the definition of the VMArrayCallNative type which is the type signature of array-call functions which are used for entering and exiting wasm. The first two parameters of this function are the callee/caller VMContext values but they are both ascribed as VMOpaqueContext. This is because for the callee it's not known exactly what type the pointer has except within the context of the defining function, so this value was not changed.

For the caller parameter though it's always the case that the value passed in is indeed a VMContext. This commit reflects this fact in the type signature and removes a number of now-unnecessary casts.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 14 2025 at 17:38):

alexcrichton requested fitzgen for a review on PR #11047.

Wasmtime GitHub notifications bot (Jun 14 2025 at 17:38):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11047.

Wasmtime GitHub notifications bot (Jun 16 2025 at 15:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 15:38):

fitzgen merged PR #11047.

Last updated: Dec 06 2025 at 07:03 UTC