Stream: git-wasmtime

Topic: wasmtime / PR #11042 Use `Pin<&mut ComponentInstance>`

Wasmtime GitHub notifications bot (Jun 13 2025 at 22:02):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11042.

Wasmtime GitHub notifications bot (Jun 13 2025 at 22:02):

alexcrichton requested dicej for a review on PR #11042.

Wasmtime GitHub notifications bot (Jun 13 2025 at 22:02):

alexcrichton opened PR #11042 from alexcrichton:component-instance-pin to bytecodealliance:main:

This commit is the continuation of #10943 for component instances. The allocation/vmctx infrastructure was additionally refactored to be shared for both core and component instances since they behave the exact same way anyway. This further enables sharing various methods like vmctx_plus_offset which are pretty unsafe internally.

Like #10943 this necessitated removal of Index implementations because IndexMut is not compatible with the returned type being Pin<&mut T> so they were replaced by inherent get and get_mut methods on the component instance id type.

Closes #10933

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 13 2025 at 22:05):

alexcrichton commented on PR #11042:

cc @fitzgen you're probably also interested in these refactorings.

Wasmtime GitHub notifications bot (Jun 14 2025 at 01:30):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Jun 14 2025 at 01:52):

fitzgen merged PR #11042.

Last updated: Dec 06 2025 at 07:03 UTC