Stream: git-wasmtime

Topic: wasmtime / PR #11037 x64: Migrate some no-operand instruc...

Wasmtime GitHub notifications bot (Jun 13 2025 at 16:34):

alexcrichton opened PR #11037 from alexcrichton:x64-misc to bytecodealliance:main:

Fences, hlt, and ud2 are now all in the new assembler.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 13 2025 at 16:34):

alexcrichton requested abrown for a review on PR #11037.

Wasmtime GitHub notifications bot (Jun 13 2025 at 16:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11037.

Wasmtime GitHub notifications bot (Jun 13 2025 at 18:49):

github-actions[bot] commented on PR #11037:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:08):

abrown created PR review comment:

Just wanted to flag that we will now be using a new encoding here: 0xf4 versus 0xcc originally. 0xCC is the encoding for INT3.

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:08):

abrown submitted PR review:

Maybe we should look at this INT3 versus HLT difference?

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:09):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:09):

abrown created PR review comment:

What I mean is: this Inst variant may be misnamed (?) and previously we were always using INT3 when we emitted a Inst::Hlt. I think if we emit a HLT it's a bit more drastic...

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:39):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:39):

alexcrichton created PR review comment:

Oh good catch! I'll make sure the encoding doesn't change

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:42):

alexcrichton updated PR #11037.

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:43):

alexcrichton updated PR #11037.

Wasmtime GitHub notifications bot (Jun 16 2025 at 17:56):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 22:20):

alexcrichton updated PR #11037.

Wasmtime GitHub notifications bot (Jun 16 2025 at 22:20):

alexcrichton has enabled auto merge for PR #11037.

Wasmtime GitHub notifications bot (Jun 16 2025 at 22:55):

alexcrichton merged PR #11037.

Last updated: Dec 06 2025 at 06:05 UTC