Stream: git-wasmtime

Topic: wasmtime / PR #11029 x64: Improve external assembler ergo...

Wasmtime GitHub notifications bot (Jun 12 2025 at 18:42):

alexcrichton requested abrown for a review on PR #11029.

Wasmtime GitHub notifications bot (Jun 12 2025 at 18:42):

alexcrichton opened PR #11029 from alexcrichton:x64-improve-ergonomics to bytecodealliance:main:

Especially in the case of pseudo-instructions in x64/inst/emit.rs the goal is to reduce the amount of boilerplate necessary to emit instructions. This is done via:

• A new helper trait was added that's implemented for all assembler instructions to avoid a .into() after constructors as well as to avoid Inst::External { inst } construction.

• Pseudo-instructions are moved to using Gpr and friends instead of Reg to more naturally convert to raw assembler types.

• Some usage of Inst::* helpers is removed when it's known exactly what assembler instruction is going to be used and it's easier to use the assembler instruction instead.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 12 2025 at 18:42):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11029.

Wasmtime GitHub notifications bot (Jun 12 2025 at 18:42):

alexcrichton commented on PR #11029:

cc @fitzgen

Wasmtime GitHub notifications bot (Jun 12 2025 at 19:14):

abrown submitted PR review:

I'm fine with this; let's see what @fitzgen thinks. I think there is more that can be done along this path in the future to make things more ergonomic.

Wasmtime GitHub notifications bot (Jun 12 2025 at 19:33):

fitzgen submitted PR review:

Big improvement IMO :+1:

Wasmtime GitHub notifications bot (Jun 12 2025 at 22:15):

alexcrichton merged PR #11029.

Last updated: Dec 06 2025 at 07:03 UTC