Stream: git-wasmtime

Topic: wasmtime / PR #11025 x64: Delete MovRR instruction variant

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 14:34):

alexcrichton requested fitzgen for a review on PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 14:34):

alexcrichton opened PR #11025 from alexcrichton:x64-rm-movrr to bytecodealliance:main:

This removes MovRR and no new instructions were needed in the
assembler as everything was already added. Lots of little updates here
and there but everything pretty straightforward. Much of the conversion
goop should get better over time as preexisting instructions should move
to Gpr instead of Reg which would avoid the need for conversions at
all.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 14:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 15:43):

fitzgen created PR review comment:

Would be nice to have an emit_asm helper or something so that every call site doesn't need to do the whole .into(); Inst::External { inst }.emit(...) dance. Because the new version of everything here is a lot harder to read.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 15:43):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 18:05):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 18:05):

alexcrichton created PR review comment:

I mentioned this in the OP but while some impedance mismatch is what you mention another big source is using Reg in pseudo-insts instead of Gpr. I'll work on a follow-up to try to fix that.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 18:44):

alexcrichton updated PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 18:44):

alexcrichton has enabled auto merge for PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 22:12):

alexcrichton updated PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 22:16):

alexcrichton updated PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 22:16):

alexcrichton has enabled auto merge for PR #11025.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2025 at 22:51):

alexcrichton merged PR #11025.

Last updated: Dec 06 2025 at 06:05 UTC