Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15): Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15):alexcrichton opened PR #11022 from alexcrichton:x64-less-rex to bytecodealliance:main:
This commit fixes a few cases where a REX prefix is emitted for an instruction but was not actually required. The REX prefix is unconditionally emitted in situations where 8-bit registers are referenced and one of the registers referenced has an encoding between 4-7. This logic was mistakenly applied to addressing modes as well, however, where 8-bit registers are not referenced and instead 64-bit registers are used.
This commit adds a few comments, refactors a few things, and makes it such that "special registers" are not tested for operands to addressing modes (e.g. the base register).
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15):alexcrichton requested abrown for a review on PR #11022.
Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11022.
Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15):alexcrichton requested fitzgen for a review on PR #11022.
Wasmtime GitHub notifications bot (Jun 12 2025 at 01:15):alexcrichton requested wasmtime-core-reviewers for a review on PR #11022.
Wasmtime GitHub notifications bot (Jun 12 2025 at 15:36):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 12 2025 at 18:00):alexcrichton merged PR #11022.
Last updated: Dec 06 2025 at 06:05 UTC