Stream: git-wasmtime

Topic: wasmtime / PR #11018 wasmtime-wasi-io: change blocking-wr...

Wasmtime GitHub notifications bot (Jun 11 2025 at 22:37):

pchickey opened PR #11018 from bytecodealliance:pch/blocking_write_and_flush to bytecodealliance:main:

See https://github.com/WebAssembly/wasi-io/issues/109

The default implementation of blocking_write_and_flush could potentially return a Closed if the stream only becomes Closed upon completion of the flush (returned by flush or the final check_write). We don't want to propogate Closed there as an error, and instead return Ok(()) because the blocking write and its associated flush did succeed. We only want to propagate Errors as surfaced by the flush and final check_write calls.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 11 2025 at 22:37):

pchickey requested fitzgen for a review on PR #11018.

Wasmtime GitHub notifications bot (Jun 11 2025 at 22:37):

pchickey requested wasmtime-core-reviewers for a review on PR #11018.

Wasmtime GitHub notifications bot (Jun 11 2025 at 22:37):

pchickey requested alexcrichton for a review on PR #11018.

Wasmtime GitHub notifications bot (Jun 11 2025 at 22:40):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2025 at 16:30):

pchickey merged PR #11018.

Last updated: Dec 06 2025 at 07:03 UTC