Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54): Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54):abrown opened PR #11017 from abrown:asm-full-custom-display to bytecodealliance:main:
Sometimes we just want to fix up the printed name of the instruction in the disassembly; e.g., instructions with the
lockprefix. But, as we're seeing in #10836 and elsewhere, other times we want to control the printing of the entire instruction--the fullDisplayimplementation. We'll need this kind of thing if we want to swap the order of operands or omit an immediate if it ends up being included in the printed instruction name.This change splits this kind of customization in two:
MnemonicandDisplay. After renaming this enum toCustomization, all existing uses ofDisplayare migrated toMnemonic.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54):abrown requested cfallin for a review on PR #11017.
Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54):abrown requested wasmtime-compiler-reviewers for a review on PR #11017.
Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54):abrown requested alexcrichton for a review on PR #11017.
Wasmtime GitHub notifications bot (Jun 11 2025 at 21:54):abrown commented on PR #11017:
cc: @rahulchaphalkar
Wasmtime GitHub notifications bot (Jun 11 2025 at 22:01):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 11 2025 at 22:37):abrown merged PR #11017.
Last updated: Dec 06 2025 at 06:05 UTC