Wasmtime GitHub notifications bot (Jun 10 2025 at 22:07): Wasmtime GitHub notifications bot (Jun 10 2025 at 22:07):alexcrichton opened PR #11009 from alexcrichton:miri-fibers to bytecodealliance:main:
This commit extends the
wasmtime-internal-fibercrate with an implementation for Miri. Previously this was entirely unsupported because fibers use inline assembly. The implementation with Miri spawns a separate thread and keeps it in a suspended state with locks to model a suspended stack. This technically isn't correct because TLS variables will be wrong, but it's "correct enough" for our usage in Wasmtime. In the end this enables running more tests in Miri which is always a good thing, and a number of loose odds and ends were cleaned up relate to our unsafe management of async state.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:07):alexcrichton requested pchickey for a review on PR #11009.
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #11009.
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:31):pchickey created PR review comment:
/// The fiber has completed with the provided value and can no
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:31):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:31):pchickey created PR review comment:
/// The fiber execution panicked.
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:31):pchickey created PR review comment:
/// Resume with this value. Called for each invocation of
Wasmtime GitHub notifications bot (Jun 10 2025 at 22:31):pchickey created PR review comment:
/// The fiber hasn't finished but has provided the following value
Wasmtime GitHub notifications bot (Jun 11 2025 at 00:35):alexcrichton updated PR #11009.
Wasmtime GitHub notifications bot (Jun 11 2025 at 00:35):alexcrichton has enabled auto merge for PR #11009.
Wasmtime GitHub notifications bot (Jun 11 2025 at 01:07):alexcrichton merged PR #11009.
Last updated: Dec 06 2025 at 07:03 UTC